Enabling prot and ret paladin classic sims#166
Open
DaveAlessi wants to merge 5 commits intowowsims:masterfrom
Open
Enabling prot and ret paladin classic sims#166DaveAlessi wants to merge 5 commits intowowsims:masterfrom
DaveAlessi wants to merge 5 commits intowowsims:masterfrom
Conversation
…om apl, inputs.ts, presets.ts, and paladin.proto
…Fixed a few things with retribution as well but still a ways to go there. Was able to get the build running and did several end to end manual tests and everything looks pretty good as far as I can tell.
… really bad one (I don't know how to play Ret sorry)
…that I removed as well.
…o exorcism, removed the 100% crit bonus to undead and demon and instead added a check for undead and demon as was originally intended. Also removed and validated the original classic spell Ids
Author
Additional Changes (Latest Commit)Based on discord feedback, I've addressed two additional issues: Spell Implementation Fixes:
Checklist Verified:
All tests pass and I tested the UI locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of Protection and Retribution Paladin Simulators from SoD to Classic
From what I could tell, the ret and prot paladin sims were not fully migrated over from Season of Discovery (SoD). This PR migrates the prot and ret simulators from SoD to Classic by removing SoD-specific content and ensuring compatibility with Classic mechanics.
Changes Made
Protocol Buffers (
proto/paladin.proto)Martyrdom = 3from thePaladinSealenum (SoD-only seal)IsUsingDivineStormStopAttackoption (Divine Storm is a SoD rune ability)IsUsingCrusaderStrikeStopAttackoption (Crusader Strike is a SoD rune ability)IsUsingJudgementStopAttack(valid for Classic seal twisting)Retribution Paladin
sim/paladin/retribution/retribution.go: Removed Divine Storm and Crusader Strike stop attack fields from the structsim/paladin/retribution/retribution_test.go: Removed Seal of Martyrdom test options, updated tests to use Seal of Righteousnessui/retribution_paladin/inputs.ts: Removed Seal of Martyrdom from seal selection optionsui/retribution_paladin/presets.ts:DefaultOptionsto usePaladinSeal.Righteousnessbasic_ret.apl.jsonui/retribution_paladin/apls/basic_ret.apl.json: New Classic-compatible APL using Judgement and seal twisting between SoR/SoCProtection Paladin
sim/paladin/protection/protection.go: Removed Divine Storm and Crusader Strike stop attack fields from the structsim/paladin/protection/protection_test.go: Updated tests to use Seal of Righteousnessui/protection_paladin/inputs.ts: Removed Seal of Martyrdom from seal selection optionsui/protection_paladin/presets.ts:DefaultOptionsto usePaladinSeal.Righteousnessbasic_prot.apl.jsonandp5prot.apl.jsonui/protection_paladin/apls/basic_prot.apl.json: New Classic-compatible APLui/protection_paladin/apls/p5prot.apl.json: New Classic-compatible APL with defensive cooldownsRemoved SoD APL Files
Deleted Phase 4/5 SoD-specific APL files that referenced SoD rune abilities and spell IDs.
Updated index.html
Updated the index to point to
Test Results
Regenerated
TestRetribution.resultsandTestProtection.resultsto reflect the updated test configurations. This is the part I'm least sure about, tests initially failed. From what I can tell the failures were expected because all the APLs had to be updated so I used themake update-testscommand.Testing
make test)make)